Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run sim in elmer_01_electrostatic.ipynb #405

Merged
merged 5 commits into from
Jul 26, 2024
Merged

Conversation

nikosavola
Copy link
Member

Previously forgot to uncomment the running section from debugging I think

Previously forgot to uncomment the running section from debugging I think
@nikosavola nikosavola added documentation Improvements or additions to documentation simulations simulation plugins labels May 23, 2024
@nikosavola nikosavola requested a review from joamatab May 23, 2024 06:18
@nikosavola nikosavola self-assigned this May 23, 2024
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.

@nikosavola nikosavola enabled auto-merge May 23, 2024 06:19
Copy link
Contributor

@joamatab joamatab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the docs seems to fail

@nikosavola
Copy link
Member Author

the docs seems to fail

Seems to be the meep plugin

/home/runner/work/gplugins/gplugins/gplugins/gmeep/write_sparameters_meep.py:docstring of gplugins.gmeep.write_sparameters_meep.write_sparameters_meep:67: ERROR: Unknown target name: "component".

@joamatab joamatab self-requested a review July 26, 2024 18:14
@nikosavola nikosavola merged commit 94a3537 into main Jul 26, 2024
14 of 15 checks passed
@nikosavola nikosavola deleted the run-sim-in-elmer-notebook branch July 26, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation simulations simulation plugins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants