update tidy3d #378
update tidy3d #378
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
We have skipped reviewing this pull request. We don't review packaging changes - Let us know if you'd like us to change this.
|
not sure why some tests are failing with the update? https://github.com/gdsfactory/gplugins/actions/runs/8654520090/job/23731859225 |
|
I think this issue has to do with some conflicts with boto3 / urllib3 that were not set correctly when we migrated to poetry. Should be resolved with flexcompute/tidy3d#1598 We will release a 2.6.4 patch on Monday with it after some more testing. Is there a way for you to set your tests to run with tidy3d from that branch to see if it resolves it? |
|
yes, we can, but we can also wait until Monday :) we've been using quite an old version of tidy3d |
|
We think the issue is that the new tidy3d accidentally pinned |
There was a problem hiding this comment.
We have skipped reviewing this pull request. Here's why:
- We don't review packaging changes - Let us know if you'd like us to change this.
- It looks like we've already reviewed this pull request.
waiting for a new patch from tidy3d side