Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include tqdm in project dependencies #295

Merged
merged 2 commits into from
Jan 15, 2024
Merged

Conversation

sequoiap
Copy link
Contributor

@sequoiap sequoiap commented Jan 9, 2024

Lots of the code (specifically in modes) uses tqdm without listing it as an install dependency, might as well include it and avoid confusion.

Copy link
Contributor

@joamatab joamatab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Sequoia!

@joamatab joamatab merged commit 7cffa23 into gdsfactory:main Jan 15, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants