From 101631c0426316342560f06f0be31d995e32d2d4 Mon Sep 17 00:00:00 2001 From: zhylmzr Date: Mon, 1 Mar 2021 01:02:04 +0800 Subject: [PATCH 1/2] fix: abbr --add option typo --- conf.d/abbr_tips.fish | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/conf.d/abbr_tips.fish b/conf.d/abbr_tips.fish index a57fb61..9579852 100644 --- a/conf.d/abbr_tips.fish +++ b/conf.d/abbr_tips.fish @@ -30,7 +30,7 @@ function __abbr_tips --on-event fish_postexec -d "Abbreviation reminder for the # Update abbreviations lists when adding/removing abbreviations if test "$command[1]" = "abbr" - if string match -q -r '^--append|-a$' -- "$command[2]" + if string match -q -r '^--add|-a$' -- "$command[2]" and not contains -- "$command[3]" $__ABBR_TIPS_KEYS set -a __ABBR_TIPS_KEYS "$command[3]" set -a __ABBR_TIPS_VALUES "$command[4..-1]" From 5e1bf206e7f274414fe5ad1c6a6dfb121d131bac Mon Sep 17 00:00:00 2001 From: zhylmzr Date: Mon, 1 Mar 2021 02:16:41 +0800 Subject: [PATCH 2/2] ci: fix test --- test/fish-abbreviation-tips.fish | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) diff --git a/test/fish-abbreviation-tips.fish b/test/fish-abbreviation-tips.fish index 3e43c43..9b6f19c 100644 --- a/test/fish-abbreviation-tips.fish +++ b/test/fish-abbreviation-tips.fish @@ -21,8 +21,18 @@ function teardown set ABBR_TIPS_PROMPT "$tmp_tips_prompt" end +function clear_test_var + # Clear variables to prevent the results + # of each unit test from affecting each other + set -g __ABBR_TIPS_KEYS + set -g __ABBR_TIPS_VALUES +end + +setup + # Tests @test "initial tip key" ( + clear_test_var abbr -a __abbr_test ps set -e __ABBR_TIPS_KEYS __abbr_tips_init @@ -30,6 +40,7 @@ end ) "$status" = 0 @test "initial tip value" ( + clear_test_var abbr -a __abbr_test ps set -e __ABBR_TIPS_VALUES __abbr_tips_init @@ -37,68 +48,82 @@ end ) "$status" = 0 @test "add abbreviation tip key" ( + clear_test_var __abbr_tips 'abbr -a __abbr_test ps' contains "__abbr_test" $__ABBR_TIPS_KEYS ) "$status" = 0 @test "add abbreviation tip value" ( + clear_test_var __abbr_tips 'abbr -a __abbr_test ps' contains "ps" $__ABBR_TIPS_VALUES ) "$status" = 0 @test "remove abbreviation tip key" ( + clear_test_var __abbr_tips 'abbr -a __abbr_test ps' __abbr_tips 'abbr -e __abbr_test' not contains "__abbr_test" $__ABBR_TIPS_KEYS ) "$status" = 0 @test "remove abbreviation tip value" ( + clear_test_var __abbr_tips 'abbr -a __abbr_test ps' __abbr_tips 'abbr -e __abbr_test' not contains "ps" $__ABBR_TIPS_VALUES ) "$status" = 0 @test "add alias tip key" ( + clear_test_var __abbr_tips 'alias __abbr_test_alias "grep -q"' contains "a____abbr_test_alias" $__ABBR_TIPS_KEYS ) "$status" = 0 @test "add alias tip value" ( + clear_test_var __abbr_tips 'alias __abbr_test_alias "grep -q"' contains "grep -q" $__ABBR_TIPS_VALUES ) "$status" = 0 @test "add alias tip value with =" ( + clear_test_var __abbr_tips 'alias __abbr_test_alias=grep"' contains "grep" $__ABBR_TIPS_VALUES ) "$status" = 0 @test "add alias tip key with =" ( + clear_test_var __abbr_tips 'alias __abbr_test_alias=grep"' contains "a____abbr_test_alias" $__ABBR_TIPS_KEYS ) "$status" = 0 @test "remove alias tip key" ( + clear_test_var __abbr_tips 'alias __abbr_test_alias "grep -q"' __abbr_tips 'functions --erase __abbr_test_alias' not contains "a____abbr_test_alias" $__ABBR_TIPS_KEYS ) "$status" = 0 @test "remove alias tip value" ( + clear_test_var __abbr_tips 'alias __abbr_test_alias "grep -q"' __abbr_tips 'functions --erase __abbr_test_alias' not contains "grep -q" $__ABBR_TIPS_VALUES ) "$status" = 0 @test "abbreviation tip match" ( + clear_test_var __abbr_tips 'abbr -a __abbr_test ps' echo (__abbr_tips 'ps') ) = "__abbr_test => ps" @test "alias tip match" ( + clear_test_var alias __abbr_test_alias "grep -q" __abbr_tips 'alias __abbr_test_alias "grep -q"' echo (__abbr_tips 'grep -q') ) = "__abbr_test_alias => grep -q" + +teardown \ No newline at end of file