perf(gatsby-plugin-image): downsize image before extracting dominant color #35814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
LekoArts
added
topic: media
wardpeet
reviewed
Jun 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Downsize the input image before calculating the dominant color
Documentation
When calculating the dominant color for the default image placeholder, we use sharp's
stats()function. sharp uses the input image for its calculations, which gives the most accurate result, but can be very slow to calculate for large images. This PR instead resizes the image to the default blurred placeholder size, and uses that to calculate the dominant color. This may be a less accurate respresentation, but it is Good Enough for a placeholder that is only seen for a second or so at most.In my tests running on an M1 mac mini, on a selection of source images around 10MP in size, this took around 40% of the time as the status quo.
Related Issues