Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gatsby): Remove boundActionCreators #29129

Merged
merged 14 commits into from
Feb 11, 2021
Merged

feat(gatsby): Remove boundActionCreators #29129

merged 14 commits into from
Feb 11, 2021

Conversation

LekoArts
Copy link
Contributor

@LekoArts LekoArts commented Jan 21, 2021 •
edited
Loading

Description

Removes the deprecated boundActionCreators API.

Documentation

Related Issues

[ch23415]

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jan 21, 2021
@LekoArts LekoArts added topic: internal and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jan 21, 2021
@gatsbyjs gatsbyjs deleted a comment from shortcut-integration bot Jan 21, 2021
@LekoArts LekoArts added the topic: plugins Related to plugin system, themes & catch-all for plugins that don't have a label label Jan 29, 2021
@LekoArts LekoArts marked this pull request as ready for review February 2, 2021 10:04
wardpeet
wardpeet reviewed Feb 10, 2021
View reviewed changes
Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, left 2 comments

packages/gatsby/src/utils/dev-ssr/render-dev-html.ts Outdated Show resolved Hide resolved
packages/gatsby/src/services/create-pages.ts Outdated Show resolved Hide resolved
@wardpeet wardpeet changed the title gatsby: Remove boundActionCreators feat(gatsby): Remove boundActionCreators Feb 10, 2021
laurieontech
laurieontech previously approved these changes Feb 10, 2021
View reviewed changes
Copy link
Contributor

@laurieontech laurieontech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like Ward's comments have been addressed and the code looks reasonable otherwise!

@LekoArts LekoArts merged commit b1f8663 into master Feb 11, 2021
@LekoArts LekoArts deleted the v3/bound-action-creators branch February 11, 2021 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wardpeet wardpeet wardpeet approved these changes

@laurieontech laurieontech laurieontech left review comments

Assignees
No one assigned
Labels
topic: plugins Related to plugin system, themes & catch-all for plugins that don't have a label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LekoArts @wardpeet @laurieontech