Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby-plugin-sharp): Add avif to pipeline #28871

Merged
merged 1 commit into from
Jan 5, 2021
Merged

fix(gatsby-plugin-sharp): Add avif to pipeline #28871

merged 1 commit into from
Jan 5, 2021

Conversation

ascorbic
Copy link
Contributor

@ascorbic ascorbic commented Jan 5, 2021

Adds explicit avif() call to pipeline. It works locally without this, but fails in cloud worker

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jan 5, 2021
@ascorbic ascorbic added topic: media Related to gatsby-plugin-image, or general image/media processing topics and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jan 5, 2021
@ascorbic ascorbic added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Jan 5, 2021
@gatsbybot gatsbybot merged commit 1debff5 into master Jan 5, 2021
@gatsbybot gatsbybot deleted the fix/avuf-pipeline branch January 5, 2021 17:24
@gatsbybot gatsbybot mentioned this pull request Jan 5, 2021
Merged
vladar pushed a commit that referenced this pull request Jan 5, 2021
@ascorbic @vladar
fix(gatsby-plugin-sharp): Add avif to pipeline (#28871)
2ace891 
(cherry picked from commit 1debff5)
sidharthachatterjee
sidharthachatterjee reviewed Jan 5, 2021
View reviewed changes
packages/gatsby-plugin-sharp/src/process-file.js
@@ -123,6 +123,10 @@ exports.processFile = (file, transforms, options = {}) => {
quality: transformArgs.quality,
force: transformArgs.toFormat === `tiff`,
})
.avif({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦🏼

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It didn't actually need it!

vladar pushed a commit that referenced this pull request Jan 5, 2021
@ascorbic
fix(gatsby-plugin-sharp): Add avif to pipeline (#28871) (#28876)
ecebdd3 
(cherry picked from commit 1debff5)

Co-authored-by: Matt Kane <matt@gatsbyjs.com>
@persocon
Copy link

clonedPipeline.resize(...).png(...).webp(...).tiff(...).avif is not a function 🤷‍♀️

@ascorbic
Copy link
Contributor Author

ascorbic commented Jan 11, 2021 •
edited
Loading

@persocon You need to upgrade sharp

rm3l added a commit to rm3l/rm3l.org that referenced this pull request Jan 25, 2021
@rm3l
Fix build issues by upgrading Sharp [1]
3c2856b 
[1] gatsbyjs/gatsby#28871 (comment)
rm3l added a commit to rm3l/rm3l.org that referenced this pull request Jan 25, 2021
@rm3l
Fix build issues by upgrading Sharp [1]
7afdde8 
[1] gatsbyjs/gatsby#28871 (comment)
@saurabharch saurabharch mentioned this pull request Nov 4, 2022
Open
@nidhi42 nidhi42 mentioned this pull request Nov 4, 2022
Open
@ajesse11x ajesse11x mentioned this pull request Nov 4, 2022
Open
@nidhi42 nidhi42 mentioned this pull request Nov 5, 2022
Open
This was referenced Nov 5, 2022
Open
Open
@nidhi42 nidhi42 mentioned this pull request Nov 5, 2022
Open
@kaocher82 kaocher82 mentioned this pull request Nov 5, 2022
Open
This was referenced Nov 5, 2022
Open
Open
@ajesse11x ajesse11x mentioned this pull request Nov 5, 2022
Open
@kaocher82 kaocher82 mentioned this pull request Nov 5, 2022
Open
@0xSebin 0xSebin mentioned this pull request Nov 5, 2022
Open
@ajesse11x ajesse11x mentioned this pull request Nov 5, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Nov 6, 2022
Open
@saurabharch saurabharch mentioned this pull request Dec 25, 2022
Open
@nidhi42 nidhi42 mentioned this pull request Dec 25, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Dec 25, 2022
Open
@ajesse11x ajesse11x mentioned this pull request Dec 25, 2022
Open
@kaocher82 kaocher82 mentioned this pull request Dec 25, 2022
Open
@0xSebin 0xSebin mentioned this pull request Dec 25, 2022
Open
@ajesse11x ajesse11x mentioned this pull request Dec 25, 2022
Open
@nidhi42 nidhi42 mentioned this pull request Dec 25, 2022
Open
This was referenced Dec 25, 2022
Open
Open
@nidhi42 nidhi42 mentioned this pull request Dec 25, 2022
Open
@kaocher82 kaocher82 mentioned this pull request Dec 26, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Dec 26, 2022
Open
@0xSebin 0xSebin mentioned this pull request Dec 26, 2022
Open
@kaocher82 kaocher82 mentioned this pull request Dec 27, 2022
Open
@nidhi42 nidhi42 mentioned this pull request Jun 21, 2023
Open
@ajesse11x ajesse11x mentioned this pull request Jun 21, 2023
Open
@saurabharch saurabharch mentioned this pull request Jun 21, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sidharthachatterjee sidharthachatterjee sidharthachatterjee left review comments

@fk fk fk approved these changes

Assignees
No one assigned
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes topic: media Related to gatsby-plugin-image, or general image/media processing topics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ascorbic @persocon @fk @sidharthachatterjee @gatsbybot