Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gatsby-source-contentful): Add gatsbyImageData resolver #28236

Merged
merged 19 commits into from
Jan 28, 2021
Merged

feat(gatsby-source-contentful): Add gatsbyImageData resolver #28236

merged 19 commits into from
Jan 28, 2021

Conversation

ascorbic
Copy link
Contributor

@ascorbic ascorbic commented Nov 23, 2020 •
edited
Loading

This PR adds support for a gatsbyImageData resolver to gatsby-source-contentful. We will later add a custom hook to allow runtime dynamic image support, but this is just a replacement the existing resolvers. For now we are not adding it to the docs, but adding support to allow testing on real sites.

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Nov 23, 2020
@ascorbic ascorbic changed the title Feat/contentful image helper feat(gatsby-source-contentful): Add gatsbyImageData resolver Nov 23, 2020
@ascorbic ascorbic marked this pull request as draft November 23, 2020 11:27
@ascorbic ascorbic mentioned this pull request Nov 23, 2020
Merged
@ascorbic ascorbic added topic: source-contentful Related to Gatsby's integration with Contentful topic: media Related to gatsby-plugin-image, or general image/media processing topics and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Nov 23, 2020
@delete-merged-branch delete-merged-branch bot deleted the branch master November 26, 2020 13:14
@axe312ger axe312ger self-assigned this Dec 10, 2020
@axe312ger axe312ger changed the base branch from feat/image-helpers to master December 11, 2020 13:06
@axe312ger axe312ger changed the base branch from master to gatsby-plugin-image/e2e-tests December 11, 2020 13:11
@axe312ger axe312ger changed the base branch from gatsby-plugin-image/e2e-tests to master December 11, 2020 13:11
@axe312ger axe312ger added the status: needs core review Currently awaiting review from Core team member label Dec 11, 2020
@axe312ger axe312ger marked this pull request as ready for review December 22, 2020 11:19
@KyleAMathews KyleAMathews mentioned this pull request Jan 10, 2021
Merged
@axe312ger axe312ger force-pushed the feat/contentful-image-helper branch 3 times, most recently from 9597efb to c7e2195 Compare January 15, 2021 15:41
Himanshu-27 and others added 11 commits January 25, 2021 13:18
@Himanshu-27 @axe312ger
chore(docs): Netlify CMS added branch to backend settings (#29162)
8b176ef
@mottox2 @axe312ger
docs: fix broken link (#29163)
9a6c7a9
@yonatanLehman @LekoArts @axe312ger
chore(docs): Update debugging-the-build-process (#29067)
66f4f7b 
Co-authored-by: gatsbybot <mathews.kyle+gatsbybot@gmail.com>
Co-authored-by: Lennart <lekoarts@gmail.com>
@alexleventer @LekoArts @axe312ger
chore(docs): Add cassandra to list of database sources (#29137)
ed0422a 
Co-authored-by: Lennart <lekoarts@gmail.com>
@axe312ger
feat(contentful): add support for gatsby-plugin-image
8d1eb91
@axe312ger
make gatsby-plugin-image a dependency again and warn users about the …
4376b9e 
…beta feature
@axe312ger
WIP - support traced svgs again
0c03cbb
@axe312ger @ascorbic
Update packages/gatsby-source-contentful/src/extend-node-type.js
146cd23 
Co-authored-by: Matt Kane <matt@gatsbyjs.com>
@axe312ger
fix: set progressive jpg parameter only when format is forced to jpg
44483c1
@axe312ger
feat: add support for contentful backgorund parameter
b3d2ac8
@axe312ger
feat: add support for dominant color placeholder
4630e58
laurieontech
laurieontech previously approved these changes Jan 28, 2021
View reviewed changes
Copy link
Contributor

@laurieontech laurieontech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple small comments, but I wouldn't consider them blocking. So up to you.

packages/gatsby-source-contentful/src/extend-node-type.js Outdated Show resolved Hide resolved
packages/gatsby-source-contentful/src/extend-node-type.js Outdated Show resolved Hide resolved
@ascorbic ascorbic added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Jan 28, 2021
@ascorbic ascorbic merged commit a823622 into master Jan 28, 2021
@ascorbic ascorbic deleted the feat/contentful-image-helper branch January 28, 2021 15:35
This was referenced Mar 13, 2021
Closed
Closed
@snyk-bot snyk-bot mentioned this pull request Jul 21, 2021
Open
@X-oss-byte X-oss-byte mentioned this pull request Sep 23, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wardpeet wardpeet wardpeet left review comments

@axe312ger axe312ger axe312ger requested changes

@laurieontech laurieontech laurieontech approved these changes

Assignees

@axe312ger axe312ger

Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes status: needs core review Currently awaiting review from Core team member topic: media Related to gatsby-plugin-image, or general image/media processing topics topic: source-contentful Related to Gatsby's integration with Contentful
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@ascorbic @wardpeet @axe312ger @laurieontech @nathanchu @Himanshu-27 @mottox2 @yonatanLehman @alexleventer