-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gatsby-source-filesystem): env flag to placeholder remote assets #27663
Conversation
…eholder for remote asset
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you split up processRemoteNode
so you'll have a fetch remote file so it's easier to read.
I'm more fan to save a placeholder inside the source-plugin and use it when GATSBY_EXPERIMENTAL_REMOTE_FILE_PLACEHOLDER instead of setting your own.
Considered that but I didn't really want to rely on a certain file to be present for this case and I didn't want to inline a base64 image either. I'll split it up |
Danger run resulted in 1 fail and 1 markdown; to find out more, see the checks page. Generated by 🚫 dangerJS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :) Happy debugging ;)
…gatsbyjs#27663) * feat(gatsby-source-filesystem): add experimental env flag to use placeholder for remote asset * Split up placeholder from remote * reduce patch
This is an experimental env flag to help with debugging. It replaces any remote asset that is fetched through
createRemoteFileNode
with a local placeholder file. The path is used as is.This helps with debugging and profiling sites where the remote assets are not necessary but still take minutes to download. Not meant to be used with regular sites so it's only exposed as an experimental flag.