Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby-plugin-sharp): sort nested options #15459

Merged
merged 3 commits into from
Jul 6, 2019
Merged

fix(gatsby-plugin-sharp): sort nested options #15459

merged 3 commits into from
Jul 6, 2019

Conversation

Annnnnieee
Copy link
Contributor

Description

updated sharp plugin to sort nested options

Related Issues

Fixes #14551

@Annnnnieee Annnnnieee requested a review from a team as a code owner July 5, 2019 21:54
pieh
pieh approved these changes Jul 6, 2019
View reviewed changes
Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks @Annnnnieee!

@pieh pieh merged commit 6ea8c29 into gatsbyjs:master Jul 6, 2019
@gatsbot
Copy link

gatsbot bot commented Jul 6, 2019

Holy buckets, @Annnnnieee — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@pieh
Copy link
Contributor

pieh commented Jul 6, 2019

Published gatsby-plugin-sharp@2.2.3

@Annnnnieee Annnnnieee deleted the fix/sharp-caching branch July 7, 2019 01:16
johno pushed a commit to johno/gatsby that referenced this pull request Jul 17, 2019
@Annnnnieee @johno
fix(gatsby-plugin-sharp): sort nested options (gatsbyjs#15459)
b5498be 
* fixed arg digest sorting

* reveresed key order

* fixed test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pieh pieh pieh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add DuoTone options to cache key
2 participants
@Annnnnieee @pieh