Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby-source-filesystem): pin chokidar@2.1.2 to fix unix issues #12759

Merged
merged 3 commits into from
Mar 22, 2019

Conversation

DSchau
Copy link
Contributor

@DSchau DSchau commented Mar 22, 2019

Description

Fixes apparent regression introduced in #11992

Related Issues

Preliminary guess is that something changed in paulmillr/chokidar#791 (specifically, chokidar@2.1.3) which breaks some fs operations/reads on Linux. Doesn't seem to impact MacOS.

@DSchau
Copy link
Contributor Author

DSchau commented Mar 22, 2019

The e2e tests will probably still fail here--because we're not installing new versions of dependencies in the e2e tests themselves.

@DSchau
Copy link
Contributor Author

DSchau commented Mar 22, 2019

Let's close for now--it seems like chokidar may have published a patch version.

@freiksenet freiksenet changed the title fix(gatsby-source-filesystem): revert to chokidar@1 to fix unix issues fix(gatsby-source-filesystem): pin chokidar@2.1.2 to fix unix issues Mar 22, 2019
@DSchau DSchau requested a review from a team as a code owner March 22, 2019 13:16
@DSchau
Copy link
Contributor Author

DSchau commented Mar 22, 2019

e2e tests are expected to fail because we don't update the version of deps (currently).

Let's merge and publish.

@DSchau DSchau merged commit 0ea1505 into gatsbyjs:master Mar 22, 2019
@DSchau
Copy link
Contributor Author

DSchau commented Mar 22, 2019

Successfully published:
 - gatsby-plugin-page-creator@2.0.11
 - gatsby-source-contentful@2.0.42
 - gatsby-source-drupal@3.0.32
 - gatsby-source-filesystem@2.0.28
 - gatsby-source-mongodb@2.0.16
 - gatsby-source-shopify@2.0.22
 - gatsby-source-wordpress@3.0.49
 - gatsby@2.2.8

@DSchau DSchau deleted the fix/gatsby-source-filesystem-chokadir branch March 22, 2019 13:37
@paulmillr
Copy link

just Released 2.1.5.

mwfrost pushed a commit to mwfrost/gatsby that referenced this pull request Apr 20, 2023
…atsbyjs#12759)

* fix(gatsby-source-filesystem): revert to chokidar@1 to fix unix issues

* chore: pin to 2.1.2

* chore: pin errywhere
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants