Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider make code example more clear in "Adding analytics" #10188

Closed
Rahmon opened this issue Nov 28, 2018 · 5 comments
Closed

Consider make code example more clear in "Adding analytics" #10188

Rahmon opened this issue Nov 28, 2018 · 5 comments
Labels
stale? Issue that may be closed soon due to the original author not responding any more. type: documentation An issue or pull request for improving or updating Gatsby's documentation

Comments

@Rahmon
Copy link
Contributor

Rahmon commented Nov 28, 2018

Description

In Adding analytics page shows how to add Google Analytics in Gatsby. It's necessary install gatsby-plugin-google-analytics and add some configuration in gatsby-config.js. Currently the page show the config below:

{
      resolve: `gatsby-plugin-google-analytics`,
      options: {
        // replace "UA-XXXXXXXXX-X" with your own Tracking ID
        trackingId: "UA-XXXXXXXXX-X",
      },
},

Although the config works, I think that may be more informative:

module.exports = {
  plugins: [
    {
      resolve: `gatsby-plugin-google-analytics`,
      options: {
        // replace "UA-XXXXXXXXX-X" with your own Tracking ID
        trackingId: "UA-XXXXXXXXX-X",
      }
    }
  ]
};

In gatsby-plugin-google-analytics the example is like code above.

@Rahmon Rahmon added the type: documentation An issue or pull request for improving or updating Gatsby's documentation label Nov 28, 2018
@dorukde
Copy link

dorukde commented Nov 29, 2018

The link https://www.gatsbyjs.org/packages/gatsby-plugin-google-analytics/
gives
This site can’t be reached The web page at https://www.gatsbyjs.org/packages/gatsby-plugin-google-analytics/ might be temporarily down or it may have moved permanently to a new web address. ERR_FAILED on my computer.

@dorukde
Copy link

dorukde commented Nov 30, 2018

It was my adblocker possibly not loading it, for some reason. It is still smth to consider as a detail probably. Works on my Safari (mac) browser.

@gatsbot
Copy link

gatsbot bot commented Feb 4, 2019

Hiya!

This issue has gone quiet. Spooky quiet. 👻

We get a lot of issues, so we currently close issues after 30 days of inactivity. It’s been at least 20 days since the last update here.

If we missed this issue or if you want to keep it open, please reply here. You can also add the label "not stale" to keep this issue open!

Thanks for being a part of the Gatsby community! 💪💜

@gatsbot gatsbot bot added the stale? Issue that may be closed soon due to the original author not responding any more. label Feb 4, 2019
@gatsbot
Copy link

gatsbot bot commented Feb 15, 2019

Hey again!

It’s been 30 days since anything happened on this issue, so our friendly neighborhood robot (that’s me!) is going to close it.

Please keep in mind that I’m only a robot, so if I’ve closed this issue in error, I’m HUMAN_EMOTION_SORRY. Please feel free to reopen this issue or create a new one if you need anything else.

Thanks again for being part of the Gatsby community!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale? Issue that may be closed soon due to the original author not responding any more. type: documentation An issue or pull request for improving or updating Gatsby's documentation
Projects
None yet
Development

No branches or pull requests

2 participants