Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: require-exact-type detects nested objects #441

Merged
merged 2 commits into from
Mar 24, 2020

Conversation

Marcosld
Copy link
Contributor

require-exact-type should now detect all object type declarations, not just type aliases. It will also check for nested notations (#376 ).

Also added a fixer.

@@ -19,7 +19,7 @@
"chai": "^4.2.0",
"eclint": "^2.8.1",
"eslint": "^5.13.0",
"eslint-config-canonical": "^17.3.4",
"eslint-config-canonical": "^18.1.1",
Copy link
Contributor Author

@Marcosld Marcosld Mar 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This dependency was causing an error because in this commit import-js/eslint-plugin-import@1a3a128 one of the dependent rules was updated.

@@ -88,7 +88,7 @@ const generateOrderedList = (context, sort, properties) => {
const beforePunctuator = source.getTokenBefore(nextPunctuator, {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reported by rules when I updated the plugin (prefer slice to substring)

@@ -7,199 +7,199 @@ export default {
// "always" (by default)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keys were unordered (linting rule)

@Marcosld
Copy link
Contributor Author

@gajus

@gajus gajus merged commit 463b74e into gajus:master Mar 24, 2020
@gajus
Copy link
Owner

gajus commented Mar 24, 2020

🎉 This PR is included in version 4.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@gajus gajus added the released label Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants