Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Expecto's Task tests #1105

Merged
merged 1 commit into from
Apr 19, 2023
Merged

Handle Expecto's Task tests #1105

merged 1 commit into from
Apr 19, 2023

Conversation

ratsclub
Copy link
Contributor

WHAT

Handle Expecto's Task tests

WHY

haf/expecto#445

HOW

Added the string cases to the conditional.

Copy link
Member

@TheAngryByrd TheAngryByrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@baronfel
Copy link
Contributor

Thanks @ratsclub - happy to merge this as soon as you can address the test changes that @TheAngryByrd mentioned above.

Copy link
Member

@TheAngryByrd TheAngryByrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TheAngryByrd TheAngryByrd merged commit 4edbebd into ionide:main Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants