Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes tooltips on tokens that had a trailing left paren #1023

Merged
merged 1 commit into from
Oct 10, 2022
Merged

Fixes tooltips on tokens that had a trailing left paren #1023

merged 1 commit into from
Oct 10, 2022

Conversation

TheAngryByrd
Copy link
Member

@TheAngryByrd TheAngryByrd commented Oct 10, 2022 •
edited
Loading

Previous tooltips weren't showing when hovering over the MailboxProcessor<string>.Start( of code like:

let mailbox =
  MailboxProcessor<string>.Start(
    fun _ -> async.Return()
  )

image

This fixes that.

Thanks to @AngelMunoz to pairing on this with me!

@TheAngryByrd TheAngryByrd force-pushed the fixing-tooltips-on-lparen-mismatch branch from ba872b6 to 2213385 Compare October 10, 2022 02:09
@baronfel
Copy link
Contributor

Formatting, my dudes :)

Also great work! These off-by-ones have been a plague.

@TheAngryByrd TheAngryByrd force-pushed the fixing-tooltips-on-lparen-mismatch branch from 2213385 to 698a64d Compare October 10, 2022 02:32
@TheAngryByrd
Copy link
Member Author

Format On Save is set for sure now

@baronfel baronfel merged commit 5dc14b1 into ionide:main Oct 10, 2022
@TheAngryByrd TheAngryByrd deleted the fixing-tooltips-on-lparen-mismatch branch October 10, 2022 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TheAngryByrd @baronfel