remove markdown highlighting from completion item details #979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baronfel
commented
Jul 30, 2022
| @@ -3,7 +3,7 @@ | |||
| "isRoot": true, | |||
| "tools": { | |||
| "fake-cli": { | |||
| "version": "5.22.0", | |||
| "version": "5.23.0-alpha002", | |||
There was a problem hiding this comment.
@Krzysztof-Cieslak this prerelease fixed FAKE on newer .NET runtimes for me.
There was a problem hiding this comment.
I hit this issue on macOS/M1 when trying to build fsac a couple of months ago too
|
Is this macOS hang a known thing @Krzysztof-Cieslak? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #978 by removing backticks from signature formatting for completion items, since that field isn't markdown. One nice side effect of this is that all entry points into TipFormatter are now named, so it's more clear what context each function is used for.