Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove FAKE integration #961

Merged
merged 1 commit into from
Jul 11, 2022
Merged

Remove FAKE integration #961

merged 1 commit into from
Jul 11, 2022

Conversation

Krzysztof-Cieslak
Copy link
Member

FAKE integration was disabled anyway, and given its current state, I'm not feeling confident in it being able to quickly pick up FCS changes which are required for FSAC not to be blocked.

We can revisit the feature in the future, implementing it using a different method than depending directly on FAKE (like AST traversal to find targets)

Copy link
Contributor

@baronfel baronfel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note that we'll need a sister PR in Ionide to remove those integrations as well.

@Krzysztof-Cieslak Krzysztof-Cieslak merged commit 7ec77d2 into main Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants