add config toggles for the specific kinds of codelenses we have in a configurable way #931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baronfel
force-pushed
the
codelens-config-settings
branch
from
13f1141
to
614be90
Compare
baronfel
commented
Apr 27, 2022
baronfel
force-pushed
the
codelens-config-settings
branch
from
614be90
to
d5e6b5b
Compare
baronfel
force-pushed
the
codelens-config-settings
branch
from
d5e6b5b
to
7c48b7a
Compare
|
I'm pretty happy with this, @Krzysztof-Cieslak any thoughts/concerns? |
|
Nope, Lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds/changes the settings for CodeLens to make it possible to enable/disable the two kinds of codelenses we have currently.
It also refactors the settings for these to be more reasonable/structured/open to future expansion, but it doesn't remove the existing keys so that we don't break. We should mark the old key as deprecated in Ionide, though.
These are all added because @matthewcrews is a silly goose who finds corner cases that we should have done already.