Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change codefix for "unused self reference" to single-underscore #795

Merged
merged 6 commits into from
Jun 25, 2021
Merged

Change codefix for "unused self reference" to single-underscore #795

merged 6 commits into from
Jun 25, 2021

Conversation

pblasucci
Copy link
Contributor

  • Codefix now emits single underscore (_) instead of double (__)
  • Added "rollForward" to global.json
  • Added MSBuild.StructuredLogger as direct dependency (was transitive)

@pblasucci pblasucci changed the title Change codefix for "unused self reference" [WIP] Change codefix for "unused self reference" Jun 18, 2021
@pblasucci pblasucci changed the title [WIP] Change codefix for "unused self reference" Change codefix for "unused self reference" Jun 22, 2021
baronfel
baronfel requested changes Jun 22, 2021
View reviewed changes
Copy link
Contributor

@baronfel baronfel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great overall, just a bit of alignment left.

.paket/Paket.Restore.targets Outdated Show resolved Hide resolved
test/FsAutoComplete.Tests.Lsp/CodeFixTests.fs Outdated Show resolved Hide resolved
pblasucci and others added 6 commits June 22, 2021 16:37
@pblasucci
Change codefix for "unused self reference"
ed74bc5 
+ Codefix now emits single underscore (`_`) instead of double (`__`)
+ Added "rollForward" to global.json
+ Added MSBuild.StructuredLogger as direct dependency (was transitive)
@pblasucci
adds (not yet working) test
707dca6
@baronfel @pblasucci
enable the analyzer
24f64ed
@pblasucci
Adds tests for unused value code fix
1e8e16c
@pblasucci
improved UnusedValue test mechanics
c8c2f69
@baronfel
consolidate tests
85dd68d
@baronfel baronfel changed the title Change codefix for "unused self reference" Change codefix for "unused self reference" to single-underscore Jun 25, 2021
@baronfel baronfel merged commit 4c05188 into ionide:master Jun 25, 2021
@baronfel
Copy link
Contributor

baronfel commented Jun 25, 2021 •
edited
Loading

Thanks again for your work here, especially the back-and-forth on getting this codefix under testing!

@pblasucci
Copy link
Contributor Author

Thanks for letting me contribute. And for all the patient explanations. 👍

@pblasucci pblasucci deleted the single-underscore-unused-self-reference branch June 26, 2021 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baronfel baronfel baronfel requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pblasucci @baronfel