Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing keyword list and extra information #1226

Merged
merged 3 commits into from
Feb 18, 2024

Conversation

jkone27
Copy link
Contributor

@jkone27 jkone27 commented Jan 27, 2024

WHAT

add missing keyword infos, add nuget and paket info for #r, #time, and others,

related but not fixing the display issue: #1225

WHY

https://learn.microsoft.com/en-us/dotnet/fsharp/tools/fsharp-interactive/#f-interactive-directive-reference

Copy link
Contributor Author

@jkone27 jkone27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fsharp interactive docs infos

Copy link
Contributor

@baronfel baronfel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes seem good, with one note that I've added because we do not support paket references in scripts in FSAC.

Co-authored-by: Chet Husk <baronfel@users.noreply.github.com>
@baronfel baronfel merged commit 6f3c1d3 into ionide:main Feb 18, 2024
12 of 14 checks passed
@baronfel
Copy link
Contributor

Thanks for this - will try to get a release out this weekend, since it's an American holiday and I have more time :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants