Paket Simplify #1204
Paket Simplify #1204
Conversation
| @@ -1,4 +1,3 @@ | |||
| FSharp.Core | |||
There was a problem hiding this comment.
Are you sure we want to remove this entry?
Don't we want to have the explicit FSharp.Core reference?
There was a problem hiding this comment.
I can add it back after work. I made the assumption paket knew better than me. Silly question but why would we need to keep it if paket is saying it is 'unused'? Is this a paket bug you think?
There was a problem hiding this comment.
Hmm, that sounds a bit weird to me. Isn't F# Core always used? The compiler needs it to compile your code right?
There was a problem hiding this comment.
it's marked as a transitive dependency. I know project files have some special rules around FSharp.Core (implicit vs explicit). Probably just need to look at project.assets.json and see if it's using the transitive defined in paket.lock or the sdk version
There was a problem hiding this comment.
@1eyewonder could you log an issue on paket, with a bit of info you have at hand to reproduce it (the more the merrier), I think any paket.references to F# project that references FSharp.Core should have this line in it, and we can move this discussion to paket repository to gather more insight on what should occur.
There was a problem hiding this comment.
Yep, I can get on that later this evening. As for this PR, we are in agreeance to add FSharp.Core back in the project.references correct?
There was a problem hiding this comment.
Just check the built output in project assets json and if it’s the one in paket lock and not whatever sdk you have installed it should be fine.
There was a problem hiding this comment.
Left is paket.lock, right is project.assets.json for src/FsAutoComplete
Left is paket.lock, right is project.assets.json for benchmarks
I think we should be good to proceed
WHAT
🤖 Generated by Copilot at 6eac6bb
This pull request simplifies and cleans up the dependency management of the FsAutoComplete solution by removing unused or redundant references from the
paket.dependenciesfile and variouspaket.referencesfiles. It also adds some new references for code analysis and performance optimization in the core library and the main executable projects. Additionally, it reorganizes the build and benchmark dependencies to share a commonpaket.referencesfile.🤖 Generated by Copilot at 6eac6bb
🧹🚚➕
WHY
Simple code cleanup for the paket dependencies and references
HOW
🤖 Generated by Copilot at 6eac6bb
benchmarks/paket.referencesfile, which is shared with the benchmark projects (link)dependenciesgroup from thepaket.dependenciesfile (link)