Fixes a race condition with ProgressListener.End #1183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheAngryByrd
commented
Oct 24, 2023
|
|
||
| if stillNeedsToSend then | ||
| do! lspClient.Progress(x.Token, WorkDoneProgressEnd.Create(?message = message)) | ||
| endSent <- true |
There was a problem hiding this comment.
lspClient.Progress could get cancelled before actually sending and endSent would be set to true
nojaf
pushed a commit
to nojaf/FsAutoComplete
that referenced
this pull request
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
🤖 Generated by Copilot at 46dcebc
Fix a race condition in progress reporting for the F# language server. Ensure that the
WorkDoneProgressEndmessage is always sent last by moving theendSentflag assignment inFSharpLspClient.fs.🤖 Generated by Copilot at 46dcebc
🐛🚀🌐
WHY
HOW
🤖 Generated by Copilot at 46dcebc