Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't trigger "Replace/Prefix with _" on Wild #1083

Merged
merged 2 commits into from
Mar 19, 2023
Merged

don't trigger "Replace/Prefix with _" on Wild #1083

merged 2 commits into from
Mar 19, 2023

Conversation

dawedawe
Copy link
Contributor

@dawedawe dawedawe commented Mar 19, 2023 •
edited
Loading

I think we shouldn't offer to replace a _ with another _ or prefix it with another _ to be __

baronfel
baronfel requested changes Mar 19, 2023
View reviewed changes
Copy link
Contributor

@baronfel baronfel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great change, one nit about text slicing though.

src/FsAutoComplete/CodeFixes/RenameUnusedValue.fs Outdated Show resolved Hide resolved
@baronfel baronfel merged commit 35a8ca9 into ionide:main Mar 19, 2023
@dawedawe dawedawe deleted the dont_trigger_renameunusedvalue_on_wild branch March 19, 2023 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baronfel baronfel baronfel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dawedawe @baronfel