Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REUSE Tool does not ignore files beginning with LICENSE #1032

Closed
AliSajid opened this issue Jul 4, 2024 · 6 comments · Fixed by #1041
Closed

REUSE Tool does not ignore files beginning with LICENSE #1032

AliSajid opened this issue Jul 4, 2024 · 6 comments · Fixed by #1041

Comments

@AliSajid
Copy link

AliSajid commented Jul 4, 2024

I'm working on a project that was up until recently REUSE compliant. I had two files, LICENSE-MIT and LICENSE-APACHE in the repository to have GitHub license recognition work as well as a .reuse/dep5 and the LICENSES directory.

Today as I upgraded to reuse tool 4.0.2 from 3.0.2, I see a non-compliance warning with the above 2 license files being marked as not containing a license. As I understand from #881 that the tool ignores the files that start with LICENSE. Please advise on how to proceed here.

Repository: CogDisResLab/Kaleidoscope

@carmenbianca
Copy link
Member

Hi @AliSajid. Copying from the change log:

- Previously, any file that begins with `COPYING` or `LICENSE` was ignored. This
  has been changed. Now, files like `COPYING_README` are no longer ignored, but
  `COPYING` and `COPYING.txt` are still ignored (in other words: exact matches,
  or `COPYING` + a file extension). Idem ditto for `LICENSE`. (#886)

It should suffice to rename to LICENSE.MIT.

@sorairolake
Copy link
Contributor

LICENSE.APACHE may not be recognized correctly on https://pkg.go.dev/ (see License Disclaimer). However, this may be something the other side should fix.

@carmenbianca
Copy link
Member

This is possibly also an issue that could be solved here, although it would annoyingly require a spec bump, which is not ideal at all. I'll get back on this.

@sorairolake
Copy link
Contributor

LICENSE.APACHE may not be recognized correctly on https://pkg.go.dev/ (see License Disclaimer). However, this may be something the other side should fix.

This may be solved by merging LICENSE-MIT and LICENSE-APACHE into a single file (LICENSE):

Apache License 2.0 text

---

MIT License text

@AliSajid
Copy link
Author

AliSajid commented Jul 4, 2024

Thank you for this detailed response and I appreciate you helping me out. REUSE is a great project and I'm indebted to your team for it. Thank you.

@AliSajid AliSajid closed this as completed Jul 4, 2024
@carmenbianca
Copy link
Member

You're welcome @AliSajid ! I will re-open this issue because I am discussing it tomorrow with the team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants