Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using DragDropContextConsumer directly #466

Merged
merged 2 commits into from
Mar 19, 2019

Conversation

dolezel
Copy link
Collaborator

@dolezel dolezel commented Mar 19, 2019

DragDropContextConsumer is now exposed as part of API
react-dnd/react-dnd#1257

Fixes #459

@dolezel dolezel requested a review from wuweiweiwu March 19, 2019 07:43
@dolezel
Copy link
Collaborator Author

dolezel commented Mar 19, 2019

Copy link
Member

@wuweiweiwu wuweiweiwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for this! I'm thinking of just publishing and maintaining react-dnd-scrollzone2 kinda like rollup-typescript-plugin2

@wuweiweiwu wuweiweiwu merged commit 7bc9995 into frontend-collective:master Mar 19, 2019
@dolezel dolezel deleted the fixing_dnd branch March 19, 2019 16:57
@coveralls
Copy link

Coverage Status

Coverage remained the same at 75.579% when pulling f0e488f on dolezel:fixing_dnd into 5ea335a on frontend-collective:master.

@shiraze
Copy link

shiraze commented Nov 15, 2019

This appears to be causing a number of our tests to fail with this confusing message:

 C:\Source\React\react\node_modules\react-dnd\dist\esm\index.js:1
    ({"Object.<anonymous>":function(module,exports,require,__dirname,__filename,global,jest){export * from './common';
                                                                                             ^^^^^^

    SyntaxError: Unexpected token export

      at ScriptTransformer._transformAndBuildScript (node_modules/@jest/transform/build/ScriptTransformer.js:537:17)
      at ScriptTransformer.transform (node_modules/@jest/transform/build/ScriptTransformer.js:579:25)
      at Object.<anonymous> (node_modules/frontend-collective-react-dnd-scrollzone/lib/index.js:24:17)

This is in a react client based on Create React App

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot be used in apps with external react-dnd
4 participants