Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move ComponentSelector from dispatch API to common API #75

Open
stefan-brus-frequenz opened this issue Sep 6, 2023 · 1 comment
Open

Move ComponentSelector from dispatch API to common API #75

stefan-brus-frequenz opened this issue Sep 6, 2023 · 1 comment
Labels
part:protobuf Affects the protocol buffer definition files priority:❓ We need to figure out how soon this should be addressed status:blocked Other issues must be resolved before this can be worked on type:enhancement New feature or enhancement visitble to users
Milestone
Backlog

Comments

@stefan-brus-frequenz
Copy link
Contributor

stefan-brus-frequenz commented Sep 6, 2023 •
edited by Marenz
Loading

What's needed?

The message currently known as ComponentSelector should be moved to this repository.

Proposed solution

No response

Use cases

No response

Alternatives and workarounds

No response

Additional context

No response
@stefan-brus-frequenz stefan-brus-frequenz added type:enhancement New feature or enhancement visitble to users part:❓ We need to figure out which part is affected priority:❓ We need to figure out how soon this should be addressed labels Sep 6, 2023
@stefan-brus-frequenz stefan-brus-frequenz mentioned this issue Sep 7, 2023
Closed
@llucax llucax added part:protobuf Affects the protocol buffer definition files and removed part:❓ We need to figure out which part is affected labels Sep 11, 2023
@thomas-nicolai-frequenz thomas-nicolai-frequenz added the status:blocked Other issues must be resolved before this can be worked on label Mar 22, 2024
@thomas-nicolai-frequenz
Copy link

thomas-nicolai-frequenz commented Mar 22, 2024 •
edited
Loading

@tiyash-basu-frequenz just discussed this with @stefan-brus-frequenz and we don't feel this need moving right now as no other API uses the ComponentSelector. Also the time filter message isn't different to whats used in the Reporting API.

@tiyash-basu-frequenz tiyash-basu-frequenz added this to the Backlog milestone May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
part:protobuf Affects the protocol buffer definition files priority:❓ We need to figure out how soon this should be addressed status:blocked Other issues must be resolved before this can be worked on type:enhancement New feature or enhancement visitble to users
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
4 participants
@llucax @thomas-nicolai-frequenz @tiyash-basu-frequenz @stefan-brus-frequenz