Skip to content
This repository has been archived by the owner on Dec 8, 2017. It is now read-only.

Extract RemoteLogger to separate gwt module #26

Closed
GoogleCodeExporter opened this issue Mar 13, 2015 · 4 comments
Closed

Extract RemoteLogger to separate gwt module #26

GoogleCodeExporter opened this issue Mar 13, 2015 · 4 comments

Comments

@GoogleCodeExporter
Copy link

GWT compiler generates files for RemoteLogger servlet even if it is not
really used.

Suggestion: to move RemoteLogger configuration from
/com/allen_sauer/gwt/log/gwt-log-impl.gwt.xml to separate GWT module config
(gwt-log-REMOTE.gwt.xml)

Original issue reported on code.google.com by konstant...@gmail.com on 14 Oct 2009 at 3:00

@GoogleCodeExporter
Copy link
Author

this would also get rid of the app engine dev server startup message:

Loading modules
   com.bar.FooModule
      Validating <servlet> tags for module 'foo'
      For additional info see: file:/C:/devel/eclipse/plugins/com.google.gwt.eclipse.sdkbundle.2.0.3_2.0.3.v201002191036/gwt-2.0.3/doc/helpInfo/servletMappings.html
         [WARN] Module declares a servlet class 'com.allen_sauer.gwt.log.server.RemoteLoggerServiceImpl', but the web.xml has no corresponding declaration; please add the following lines to your web.xml:
<servlet>
  <servlet-name>remoteLoggerServiceImpl</servlet-name>
  <servlet-class>com.allen_sauer.gwt.log.server.RemoteLoggerServiceImpl</servlet-class>
</servlet>
<servlet-mapping>
  <servlet-name>remoteLoggerServiceImpl</servlet-name>
  <url-pattern>/clients/gwt-log</url-pattern>
</servlet-mapping>

is there another way to mute this message?

Original comment by pfiste...@gmail.com on 8 Jun 2010 at 6:56

@GoogleCodeExporter
Copy link
Author

The warning also ignores that people commonly use GUICE to bind the servled to 
a mapping like:

public class MyServletModule extends ServletModule {
  public void configureServlets() {
    ...
    serve("/foo/gwt-log").with(RemoteLoggerServiceImpl.class);
    ...
  }
}

Original comment by pfiste...@gmail.com on 8 Jun 2010 at 8:24

@GoogleCodeExporter
Copy link
Author

Thanks for the suggestion. Great idea.

This is done as of r504.

RemoteLogger is now activated by inheriting a module:
  <inherits name="com.allen_sauer.gwt.log.gwt-log-RemoteLogger" />
rather than setting a property as had be the case up till now:
  <set-property name="log_RemoteLogger" value="ENABLED" />

Original comment by fredsa@google.com on 15 Jul 2010 at 5:32

  • Changed state: Fixed

@GoogleCodeExporter
Copy link
Author

Released in version 3.0.3

Original comment by fredsa@google.com on 20 Jun 2011 at 11:52

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant