Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(forge vb): --ignore-immutables #8850

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

feat(forge vb): --ignore-immutables #8850

wants to merge 7 commits into from
+197 −44

Conversation

yash-atreya
Copy link
Member

@yash-atreya yash-atreya commented Sep 12, 2024 •
edited
Loading

Motivation

Closes #8849

Solution

  • Get immutable references for local deployed_bytecode and onchain_runtime_code using the offsets provided under immutableReferences in the artifact.
  • Extract these references/slices from the bytecodes before comparing
  • Accommodate runtime verification without explorer API for vanilla path + predeploys.
  • Add tests

@yash-atreya yash-atreya added C-forge Command: forge labels Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes will be requested when the pull request is marked ready for review DaniPopes is a code owner

@klkvr klkvr Awaiting requested review from klkvr klkvr will be requested when the pull request is marked ready for review klkvr is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse will be requested when the pull request is marked ready for review mattsse is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
C-forge Command: forge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(verify-bytecode): ignore immutable refs during runtime check
1 participant
@yash-atreya