bug(types): SwipeableHandlers.ref accepts null. #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hartzis
requested changes
May 14, 2019
| }) | ||
|
|
||
| handlers.ref(<div />) | ||
| handlers.ref(null) |
There was a problem hiding this comment.
awesome tests! thank you!
Fixes FormidableLabs#140. Adds test to explicitly cover this case because it seems `dtslint` doesn't catch the issue when a handlers instance is spread during an `Element` instantiation. The React types do [declare the arg correctly](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/react/index.d.ts#L85).
mastermatt
force-pushed
the
types/fix-handlers-ref-arg
branch
from
e49221b
to
504e614
Compare
hartzis
approved these changes
May 15, 2019
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #140.
Adds test to explicitly cover this case because it seems
dtslintdoesn't catch the issue when a handlers instance is spread during an
Elementinstantiation. The React types do declare the arg correctly.