Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use dolmen #202

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Use dolmen #202

merged 1 commit into from
Sep 9, 2024

Conversation

filipeom
Copy link
Member

@filipeom filipeom commented Aug 31, 2024 •
edited
Loading

Closes #204.

Breaking changes:

  • Symbol's signature
  • Smtml parser?
  • Compare functions might change order of output of models

@filipeom filipeom marked this pull request as draft August 31, 2024 08:17
@filipeom filipeom force-pushed the use-dolmen branch 11 times, most recently from 0aeb585 to 610b79f Compare September 8, 2024 18:23
@filipeom filipeom marked this pull request as ready for review September 8, 2024 23:22
@filipeom
Copy link
Member Author

filipeom commented Sep 8, 2024

@joaomhmpereira It's currently working for: Bool, Int, and Real. See the tests that are passing here.

Should we merge this? I think it's good enough for now. We can add Bitv and Fps in a separate PR

@joaomhmpereira
Copy link
Member

Should we merge this? I think it's good enough for now. We can add Bitv and Fps in a separate PR

Yes, this looks very good!

@filipeom filipeom merged commit adf1315 into main Sep 9, 2024
10 checks passed
@filipeom filipeom deleted the use-dolmen branch September 9, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
breaking priority: critical type: feature
Projects
Smtml: TACAS'25 tool paper
Status: state: done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use dolmen parser
2 participants
@filipeom @joaomhmpereira