Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Managing plot style #174

Closed
TomDonoghue opened this issue Jun 9, 2020 · 1 comment
Closed

Managing plot style #174

TomDonoghue opened this issue Jun 9, 2020 · 1 comment
Assignees
@ryanhammonds
Labels
2.0 Targetted for the specparam 2.0 release. enhancement

Comments

@TomDonoghue
Copy link
Member

The plot style management for the pre-defined plots in FOOOF is not as flexible as it could be. I think we now have a better approach for doing this in NDSP that could be used as a model to update some of this management in FOOOF. I think things are already similar enough to do this in FOOOF without any breaking changes, in a way that mimics what was updated in NDSP in neurodsp-tools/neurodsp#185

Note: this issue came up in part with discussions with @tyfarnan on work with custom plots.
@ryanhammonds ryanhammonds mentioned this issue Jun 30, 2020
Merged
@TomDonoghue TomDonoghue added the 2.0 Targetted for the specparam 2.0 release. label Jul 18, 2020
@TomDonoghue
Copy link
Member Author

This is going in with #176

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ryanhammonds ryanhammonds

Labels
2.0 Targetted for the specparam 2.0 release. enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TomDonoghue @ryanhammonds