Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: autohide option for char mode doesn't work #231

Closed
3 tasks done
joalof opened this issue Sep 8, 2023 · 1 comment · Fixed by #260
Closed
3 tasks done

bug: autohide option for char mode doesn't work #231

joalof opened this issue Sep 8, 2023 · 1 comment · Fixed by #260
Labels
bug Something isn't working

Comments

@joalof
Copy link

joalof commented Sep 8, 2023

Did you check docs and existing issues?

  • I have read all the flash.nvim docs
  • I have searched the existing issues of flash.nvim
  • I have searched the existing issues of plugins related to this issue

Neovim version (nvim -v)

NVIM v0.9.1

Operating system/version

Ubuntu 22.04.3 LTS (wsl2)

Describe the bug

Setting the autohide option for char mode has no effect. The issue seems to be the following line

https://github.com/folke/flash.nvim/blob/8a8e74922a383c253b7f92e042b749150140c8d1/lua/flash/plugins/char.lua#L121C3-L121C3

where it is assumed that autohide will be a top-level field in Config.get("char") when it actually isn't (likely due to some issue in Config.get).

Steps To Reproduce

  1. Set opts.modes.char.autohide = true
  2. Perform any char motion.
  3. Flash is not hidden after jumping.

Expected Behavior

After jumping, flash should be hidden.

Repro

-- DO NOT change the paths and don't remove the colorscheme
local root = vim.fn.fnamemodify("./.repro", ":p")

-- set stdpaths to use .repro
for _, name in ipairs({ "config", "data", "state", "cache" }) do
  vim.env[("XDG_%s_HOME"):format(name:upper())] = root .. "/" .. name
end

-- bootstrap lazy
local lazypath = root .. "/plugins/lazy.nvim"
if not vim.loop.fs_stat(lazypath) then
  vim.fn.system({ "git", "clone", "--filter=blob:none", "https://github.com/folke/lazy.nvim.git", lazypath, })
end
vim.opt.runtimepath:prepend(lazypath)

-- install plugins
local plugins = {
  "folke/tokyonight.nvim",
  { "folke/flash.nvim", opts = {modes = { char = { autohide = true }}} },
  -- add any other plugins here
}
require("lazy").setup(plugins, {
  root = root .. "/plugins",
})

vim.cmd.colorscheme("tokyonight")
-- add anything else here
@joalof joalof added the bug Something isn't working label Sep 8, 2023
@folke folke closed this as completed in 71040c8 Oct 16, 2023
@folke
Copy link
Owner

folke commented Oct 16, 2023

The problem was actually in the default config function for char mode. See the commit.
If you didnt change that in your config, then it should all work. If you did, update yuor config function

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants