Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align multi-tenancy lockdown with documentation #116

Closed
XSpielinbox opened this issue Sep 23, 2023 · 1 comment · Fixed by #117
Closed

Align multi-tenancy lockdown with documentation #116

XSpielinbox opened this issue Sep 23, 2023 · 1 comment · Fixed by #117

Comments

@XSpielinbox
Copy link

The README.md of this project, as well as the kustomization.yaml of production and staging use one version of the multi-tenancy lockdown patch.

The flux documentation (source) uses a different version however.

The differences are:

  1. gotk-components.yaml and gotk-sync.yaml are correctly indented in the docs, whereas indentation seems wrong here.
  2. In the docs the paths are /spec/template/spec/containers/0/args/-, here they are /spec/template/spec/containers/0/args/0.
  3. The docs include an additional section that sets --no-remote-bases=true.

All in all, the version in the docs seems more up to date. Please correct me, if this assumption is wrong. I can also create an issue in the website repo as necessary.

It would be really nice, if there would be one version used everywhere. Having different versions without explanation is very confusing.

To avoid this in the future it might be better to avoid the code duplication.

@XSpielinbox XSpielinbox changed the title Update multi-tenancy lockdown Align multi-tenancy lockdown with documentation Sep 23, 2023
@XSpielinbox
Copy link
Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant