From 4e684ba570b9a36c0be8088c96b58c7f522ab72d Mon Sep 17 00:00:00 2001 From: Stuart Morgan Date: Thu, 3 Oct 2024 10:31:43 -0400 Subject: [PATCH] [video_player] Remove -Werror from Android build In https://github.com/flutter/plugins/pull/3019 -Werror was incorrectly added directly to the plugin build itself, which impacts client builds. We've since updated our builds to set these flags on the project only when building our own example app, which gives us the CI benefits of this flag without burdening clients with restrictive build settings, so this is no longer needed. Fixes https://github.com/flutter/flutter/issues/148478 --- packages/video_player/video_player_android/CHANGELOG.md | 4 ++++ .../video_player/video_player_android/android/build.gradle | 5 ----- packages/video_player/video_player_android/pubspec.yaml | 2 +- 3 files changed, 5 insertions(+), 6 deletions(-) diff --git a/packages/video_player/video_player_android/CHANGELOG.md b/packages/video_player/video_player_android/CHANGELOG.md index f0623caa96d6..a667edad3a55 100644 --- a/packages/video_player/video_player_android/CHANGELOG.md +++ b/packages/video_player/video_player_android/CHANGELOG.md @@ -1,3 +1,7 @@ +## 2.7.7 + +* Removes the flag to treat warnings as errors in client builds. + ## 2.7.6 * Fixes a [bug](https://github.com/flutter/flutter/issues/154602) where diff --git a/packages/video_player/video_player_android/android/build.gradle b/packages/video_player/video_player_android/android/build.gradle index a19d06e69426..282b6144b442 100644 --- a/packages/video_player/video_player_android/android/build.gradle +++ b/packages/video_player/video_player_android/android/build.gradle @@ -1,6 +1,5 @@ group 'io.flutter.plugins.videoplayer' version '1.0-SNAPSHOT' -def args = ["-Xlint:deprecation","-Xlint:unchecked","-Werror"] buildscript { repositories { @@ -20,10 +19,6 @@ rootProject.allprojects { } } -project.getTasks().withType(JavaCompile){ - options.compilerArgs.addAll(args) -} - apply plugin: 'com.android.library' android { diff --git a/packages/video_player/video_player_android/pubspec.yaml b/packages/video_player/video_player_android/pubspec.yaml index 1ab81efd9dcd..747c976f5ad4 100644 --- a/packages/video_player/video_player_android/pubspec.yaml +++ b/packages/video_player/video_player_android/pubspec.yaml @@ -2,7 +2,7 @@ name: video_player_android description: Android implementation of the video_player plugin. repository: https://github.com/flutter/packages/tree/main/packages/video_player/video_player_android issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+video_player%22 -version: 2.7.6 +version: 2.7.7 environment: sdk: ^3.5.0