Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing README instructions about passing the public token #906

Closed
jakubdrabik opened this issue Feb 11, 2022 · 2 comments
Closed

Confusing README instructions about passing the public token #906

jakubdrabik opened this issue Feb 11, 2022 · 2 comments
Labels

Comments

@jakubdrabik
Copy link

Right in the README, you're suggesting to pass the public token as --dart-define=ACCESS_TOKEN=ADD_YOUR_TOKEN_HERE, however, this is rather confusing since it's just related to your implementation example. ACCESS_TOKEN variable is not used anywhere under the hood of the library itself.

The README paragraph: https://github.com/flutter-mapbox-gl/maps#public-mapbox-access-token

This confusion was caused by this PR: https://github.com/flutter-mapbox-gl/maps/pull/760/files

cc @tobrun

@felix-ht
Copy link
Collaborator

feel free to open PR to fix it

@stale
Copy link

stale bot commented Apr 12, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants