fix: normalize paths for compiled JS in console messages #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #203 +/- ##
=======================================
Coverage 97.05% 97.05%
=======================================
Files 14 14
Lines 679 679
=======================================
Hits 659 659
Misses 20 20
|
jobara
reviewed
Aug 14, 2023
index.js
Outdated
| console.log(`[11ty] Writing ${options.js.outdir}/${path.basename(item)} from ${item}`); | ||
| console.log(`[11ty] Writing ${path.normalize(options.js.outdir)}/${path.basename(item)} from ${item}`); |
There was a problem hiding this comment.
I wonder if you should just use path.join here instead, which would also use the platform specific separator. According to the docs it will also normalize the result.
jobara
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We output built paths for JavaScript; Eleventy normalizes paths for its built files so this PR uses
path.normalizeto make sure the paths are formatted the same (prior to this PR it was./_site/, now it is_sitefor both the JS files and the other Eleventy-built files).