Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not all CSS properties are whitelisted #68

Closed
flavorjones opened this issue Apr 23, 2014 · 3 comments
Closed

Not all CSS properties are whitelisted #68

flavorjones opened this issue Apr 23, 2014 · 3 comments
Labels
allowlist issues related to what tags or attributes are allowed

Comments

@flavorjones
Copy link
Owner

One example is word-spacing, which is listed at http://www.w3.org/TR/CSS2/propidx.html but isn't included in Loofah's whitelist (or the whitelist in html5lib-ruby which is obviously not being maintained anymore).

There's a greated problem here of keeping whitelists up to date with specs. Perhaps we can solve both.
@flavorjones flavorjones mentioned this issue Apr 23, 2014
Closed
@doooks
Copy link

doooks commented Jan 14, 2016

list-style-type is another missing property. If I did a PR to introduce all the properties from the CSS spec is that likely to be accepted?

@flavorjones
Copy link
Owner Author

@doooks note that #142 is about to be merged which addresses list-style-type specifically.

@flavorjones flavorjones added the allowlist issues related to what tags or attributes are allowed label Oct 27, 2018
@flavorjones
Copy link
Owner Author

Note that this was addressed in v2.2.0. Sorry for not closing in a timely manner!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
allowlist issues related to what tags or attributes are allowed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@flavorjones @doooks