Added "fax" and "modem" to acceptable protocols based on rfc2806. #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! Thanks for submitting this. Looking at the RFC, I also see the |
cjba7
force-pushed
the
cjba7-add-fax-to-acceptable-protocols
branch
from
0fa21f4
to
64eadab
Compare
|
@flavorjones makes sense. I have just added it. |
|
Thank you! I've kicked off CI again, looks like the 2.5 failure is unrelated so ignore it. I'll merge when I get a block of time (later today?) and hopefully cut a release this week. |
|
Sounds good. Thanks for maintaining it! |
flavorjones
force-pushed
the
cjba7-add-fax-to-acceptable-protocols
branch
from
64eadab
to
ed2c917
Compare
[skip ci]
cjba7
changed the title
|
This has been released in Release 2.20.0 / 2023-04-01 · flavorjones/loofah. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rfc2806 and its superseding standards state
faxas an acceptable scheme.