Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: Move manifests to a saner location #1304

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Conversation

krnowak
Copy link
Member

@krnowak krnowak commented Oct 25, 2023

CI: http://jenkins.infra.kinvolk.io:8080/job/container/job/sdk/1149/cldsv/

This moves the manifests directory from sdk_container/.repo/manifests to the toplevel manifests directory. The location of manifests inside the SDK container is made a bit more consistent by moving it from /mnt/host/sources/.repo/manifests to /mnt/host/sources/src/scripts/manifests.

Other related PRs:

Reasons:

  • sdk_container/.repo/manifest is just a ridiculously obscure location for a file that sourced and checked everywhere.

  • .repo is probably a leftover from Google's repo tool, which we don't use any more.

  • I want /mnt/host/sources/ to stop being a mountpoint (this is where sdk_container directory is mounted).

    • I added (locally still, not filed a PR yet) a functionality to mount custom volumes with run_sdk_container but adding volumes to /host/mnt/sources/src makes a mess in the scripts repository. So this manifests directory move is a first step to avoid mounting sdk_container directory to /mnt/host/sources. We could instead mount coreos-overlay and portage-stable in /mnt/host/sources/src/third_party.
    • Maybe in future we could have /mnt/scripts as a mountpoint only, without this sources/src/third_party nonsense.
  • Changelog entries added in the respective changelog/ directory (user-facing change, bug fix, security fix, update)

    • no changelog added, that's not a user visible change
  • Inspected CI output for image differences: /boot and /usr size, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.

    • no surprises from this PR

@krnowak krnowak marked this pull request as ready for review October 26, 2023 09:11
@krnowak krnowak requested a review from a team October 26, 2023 09:11
@krnowak
Copy link
Member Author

krnowak commented Oct 26, 2023

CI passed.

@github-actions
Copy link

Build action triggered: https://github.com/flatcar/scripts/actions/runs/6651965781

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Testing / in Review
Development

Successfully merging this pull request may close these issues.

1 participant