Quote config #742
Merged
Quote config #742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cs/dbt into quote-config
drewbanin
reviewed
Apr 24, 2018
dbt/project.py
Outdated
| 'behavior for Snowflake will change in a future release, ' | ||
| 'so it is recommended that you define this explicitly. ' | ||
| '\n\n' | ||
| 'For more information, see ADD LINK') |
dbt/adapters/snowflake/relation.py
Outdated
| @@ -11,7 +11,7 @@ class SnowflakeRelation(DefaultRelation): | |||
| 'quote_policy': { | |||
| 'database': False, | |||
| 'schema': False, | |||
| 'identifier': False, | |||
| 'identifier': True, | |||
There was a problem hiding this comment.
should we quote both schema and identifier here? Feels weird to do one and not the other
dbt/main.py
Outdated
| @@ -175,6 +175,7 @@ def invoke_dbt(parsed): | |||
| profile_to_load=parsed.profile, | |||
| args=parsed | |||
| ) | |||
| proj.log_warnings() | |||
There was a problem hiding this comment.
we should do this check on line 235. If --target is used on the CLI, then this will refer to the wrong target. Probably not an issue for most, but i just got snagged locally
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.