Use root project instead of package project in context generator #538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmcarthur
approved these changes
Sep 26, 2017
| @@ -218,7 +218,7 @@ def parse_node(node, node_path, root_project_config, package_project_config, | |||
| config_dict.update(config.config) | |||
| node['config'] = config_dict | |||
|
|
|||
| context = dbt.context.parser.generate(node, package_project_config, | |||
| context = dbt.context.parser.generate(node, root_project_config, | |||
There was a problem hiding this comment.
ok, so in dbt.context.common.generate, we only want the root project config. can you also double check:
dbt/context/runtime.py line 94
dbt/node_runners.py line 377
if you do that then this is approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug (introduced by custom schemas) caused models defined in dependency projects to use the schema associated with the default target for a profile.
So,
would use
analyticsfor models in the root project, while it would use eg.dbt_dbaninfor models in dependency packages.Part of the problem is this line here
@cmcarthur do you think this is a sufficient fix? Kind of a tricky bug here