Fix a regression where dbt ignored aliases in config() calls #2559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@beckjake this LGTM as-is, but one QQ. I noticed that setting the same config in the This is just a long-standing open issue and not a regression as far as I can tell. Let's be sure to fix that one soon though. I could have sworn we had an open issue for it, but I couldn't find one, so I created a new ticket here: #2562 |
drewbanin
approved these changes
Jun 17, 2020
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2557
Description
The new
config()-handling code just doesn't have the alias logic. This PR adds it back in.I updated an existing test to catch this issue in the future.
Checklist
CHANGELOG.mdand added information about my change to the "dbt next" section.