fix get_columns_in_relation on snowflake (#2504) #2509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add a test for adapter methods to catch this if it regresses
drewbanin
approved these changes
Jun 1, 2020
beckjake
changed the title
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add a test for adapter methods to catch this if it regresses
resolves #2504
Description
This was a regression caused by using
describe table ...instead of selecting from the information schema, and not catching the exception when that happened on a missing table. Previously, and on all other adapters, this results in an empty list.This is pretty straightforward, we've done it plenty of other places.
Checklist
CHANGELOG.mdand added information about my change to the "dbt next" section.