Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Direct child model selector #2485

Merged
merged 9 commits into from
May 26, 2020
Merged

Direct child model selector #2485

merged 9 commits into from
May 26, 2020

Conversation

Raalsky
Copy link
Contributor

@Raalsky Raalsky commented May 24, 2020 •
edited
Loading

resolves #2052

Description

Extends model selection syntax with at most n-th parent/children dbt run --models 3+m1+2

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt next" section.

@cla-bot cla-bot bot added the cla:yes label May 24, 2020
beckjake
beckjake suggested changes May 26, 2020
View reviewed changes
Copy link
Contributor

@beckjake beckjake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! I have some feedback on more style-related things, but the core behavior looks great to me. And excellent tests.

core/dbt/graph/selector.py Outdated Show resolved Hide resolved
beckjake
beckjake suggested changes May 26, 2020
View reviewed changes
Copy link
Contributor

@beckjake beckjake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This update looks great, thank you.

As I was giving the new changes a final look-through I found a couple more small things, but I think this is it.

core/dbt/graph/selector.py Outdated Show resolved Hide resolved
core/dbt/graph/selector.py Outdated Show resolved Hide resolved
core/dbt/graph/selector.py Outdated Show resolved Hide resolved
core/dbt/graph/selector.py Outdated Show resolved Hide resolved
@beckjake
Copy link
Contributor

Thanks for another great contribution @Raalsky! Tests are passing, I'll merge this in now.

@beckjake beckjake merged commit c3c99f3 into dbt-labs:dev/marian-anderson May 26, 2020
@Raalsky Raalsky deleted the direct-nodes-selector branch May 27, 2020 08:37
@jtcohen6 jtcohen6 mentioned this pull request Jul 9, 2020
Closed
@Raalsky Raalsky mentioned this pull request Jul 13, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beckjake beckjake beckjake approved these changes

Assignees
No one assigned
Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Direct child model selector
2 participants
@Raalsky @beckjake