Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve on run end (#1924) #2031

Merged
merged 1 commit into from
Jan 6, 2020
Merged

improve on run end (#1924) #2031

merged 1 commit into from
Jan 6, 2020

Conversation

beckjake
Copy link
Contributor

@beckjake beckjake commented Jan 6, 2020

Fixes #1924

Add a database_schemas value to the on-run-end context. The name is terrible, suggestions welcome!

add db, schema pairs to the context
ff9013d 
Update tests to use that information
@cla-bot cla-bot bot added the cla:yes label Jan 6, 2020
@drewbanin drewbanin changed the base branch from dev/0.15.1 to dev/barbara-gittings January 6, 2020 20:36
drewbanin
drewbanin approved these changes Jan 6, 2020
View reviewed changes
Copy link
Contributor

@drewbanin drewbanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM! I can't think of a better name than database_schemas - ship it

@beckjake beckjake merged commit b9a47ca into dev/barbara-gittings Jan 6, 2020
@beckjake beckjake deleted the feature/improve-on-run-end branch January 6, 2020 22:05
@drewbanin drewbanin mentioned this pull request Jan 6, 2020
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewbanin drewbanin drewbanin approved these changes

Assignees
No one assigned
Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@beckjake @drewbanin