Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add auto dist style #1885

Merged

Conversation

tjengel
Copy link
Contributor

@tjengel tjengel commented Nov 3, 2019

This pr adds 'auto' as a diststyle for redshift. Fixes issue #1882

@cla-bot
Copy link

cla-bot bot commented Nov 3, 2019

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, don't hesitate to ping @drewbanin.

CLA has not been signed by users: @tjengel

@drewbanin
Copy link
Contributor

drewbanin commented Nov 4, 2019

Thanks @tjengel! This looks great :)

Are you able to rebase this change into a single commit? I'm going to kick off the tests here anyway just to make sure there's nothing funky going on. @cla-bot check

@cla-bot cla-bot bot added the cla:yes label Nov 4, 2019
@cla-bot
Copy link

cla-bot bot commented Nov 4, 2019

The cla-bot has been summoned, and re-checked this pull request!

@tjengel
Copy link
Contributor Author

tjengel commented Nov 5, 2019

@drewbanin What branch should I be rebasing to?

@drewbanin
Copy link
Contributor

drewbanin commented Nov 5, 2019 via email

@tjengel
Copy link
Contributor Author

tjengel commented Nov 6, 2019

@drewbanin This should be good to go now

@drewbanin
Copy link
Contributor

@tjengel this LGTM but something weird happened with the test suite. I just kicked these tests off again - will merge it when they pass :)

@beckjake
Copy link
Contributor

beckjake commented Nov 8, 2019

Hi @tjengel, could you merge the latest dev/louisa-may-alcott in to this branch? It has a dependency fix that I think will get your tests happy again!

@tjengel
Copy link
Contributor Author

tjengel commented Nov 8, 2019

@beckjake This is done

@beckjake
Copy link
Contributor

beckjake commented Nov 9, 2019

Merging this now, thanks for your contribution @tjengel!

@beckjake beckjake merged commit 2ca4c1a into dbt-labs:dev/louisa-may-alcott Nov 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants