Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add disallowed project names list to dbt projects (#1696) #1748

Merged
merged 1 commit into from
Sep 13, 2019
Merged

add disallowed project names list to dbt projects (#1696) #1748

merged 1 commit into from
Sep 13, 2019

Conversation

beckjake
Copy link
Contributor

@beckjake beckjake commented Sep 13, 2019 •
edited
Loading

Fixes #1696

  • Raise ValidationErrors on disallowed project names
  • Set defaults in project contract to make testing easier (project contracts should probably just be part of the Project class!)
  • Add some trivial unit tests
  • Removed an empty unit test file, which makes me a bit anxious... what did I do there?

add disallowed project names list to dbt projects
cfb55ef 
Raise on disallowed project names
Set defaults in project contract for testability
Add tests
@cla-bot cla-bot bot added the cla:yes label Sep 13, 2019
drewbanin
drewbanin approved these changes Sep 13, 2019
View reviewed changes
Copy link
Contributor

@drewbanin drewbanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This LGTM

@beckjake beckjake merged commit 3ebe95d into dev/louisa-may-alcott Sep 13, 2019
@beckjake beckjake deleted the feature/context-blacklist branch September 13, 2019 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewbanin drewbanin drewbanin approved these changes

Assignees
No one assigned
Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

if a package name shadows internal context members, terrible things happen
2 participants
@beckjake @drewbanin