Fix for run and docs generate on Panoply Redshift #1686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmcarthur
approved these changes
Aug 19, 2019
| @@ -80,7 +80,7 @@ | |||
| numeric_precision, | |||
| numeric_scale | |||
|
|
|||
| from {{ relation.information_schema('columns') }} | |||
There was a problem hiding this comment.
how confident are you that this is equivalent
There was a problem hiding this comment.
yeah - should be the same thing. This is definitely not equivalent on BQ/Snowflake, but on Redshift, you can only access the information_schema for the database that you're connected to. Turns out Redshift ignores capitalization in even quoted identifiers, so all of these are equivalent 🙃
select * from information_schema.columns;
select * from information_schema."columns";
select * from information_schema."COLUMNS";
|
👏 Thanks guys! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks @gautam-ndk for your help in debugging this!
Panoply has two sql rewriting bugs:
columnscause problems; I am quoting or renaming them herefixes #1479