Remove sql_where #1408
Merged
Remove sql_where #1408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks ok to me, but @drewbanin should have a look |
|
This LGTM but now might just be a good time to delete the |
drewbanin
approved these changes
Apr 22, 2019
| {# If a user is not using sql_where, there's no need for a subselect #} | ||
| {{ sql }} | ||
| {%- endif -%} | ||
| {{ sql }} |
There was a problem hiding this comment.
we probably don't need tmp_table_sql anymore
beckjake
force-pushed
the
fix/remove-sql_where-from-subquery
branch
from
0d7b9ab
to
f85c145
Compare
beckjake
changed the title
beckjake
force-pushed
the
fix/remove-sql_where-from-subquery
branch
from
f85c145
to
0885be1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1351
Remove sql_where, solving all
sql_where-related issues permanently.