Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

persist_docs should consider column quoting #2539

Closed
3 of 4 tasks
drewbanin opened this issue Jun 11, 2020 · 2 comments · Fixed by #2733
Closed
3 of 4 tasks

persist_docs should consider column quoting #2539

drewbanin opened this issue Jun 11, 2020 · 2 comments · Fixed by #2733
Assignees
Labels
bug Something isn't working good_first_issue Straightforward + self-contained changes, good for new contributors!
Milestone

Comments

@drewbanin
Copy link
Contributor

Describe the bug

When running a dbt run, sql statements to persist docs are failing for columns that must be quoted. dbt does not currently respect the quote config when building these DDL statements.

Steps To Reproduce

# dbt_project.yml
name: debug
version: 1.0.0
config-version: 2

models:
  +persist_docs:
    columns: true
-- models/my_model.sql
select 1 as "2id"
# models/schema.yml

version: 2

models:
  - name: debug
    columns:
      - name: 2id
        description: "my description"
        quote: true

Finally, execute dbt run and observe that persisting docs fails.

Expected behavior

The DDL built by dbt should respect the quote config on the column declaration for a dbt node

System information

Which database are you using dbt with?

  • postgres
  • redshift
  • bigquery
  • snowflake

This probably does not affect BigQuery since quoting isn't relevant + we use the API

The output of dbt --version:

0.17.0
@drewbanin drewbanin added the bug Something isn't working label Jun 11, 2020
@drewbanin drewbanin modified the milestones: 0.17.1, Marian Anderson Jun 11, 2020
@drewbanin
Copy link
Contributor Author

This is not a regression per se - moving it to the Marian Anderson milestone

@drewbanin drewbanin added the good_first_issue Straightforward + self-contained changes, good for new contributors! label Jul 6, 2020
@jtcohen6 jtcohen6 modified the milestones: Marian Anderson, 0.19.0 Aug 18, 2020
@gshank gshank self-assigned this Aug 26, 2020
@jtcohen6 jtcohen6 modified the milestones: 0.19.0, 0.18.1 Sep 1, 2020
@gshank gshank closed this as completed Sep 1, 2020
@gshank gshank reopened this Sep 1, 2020
@jtcohen6
Copy link
Contributor

jtcohen6 commented Sep 9, 2020

Resolved by #2733

@jtcohen6 jtcohen6 closed this as completed Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good_first_issue Straightforward + self-contained changes, good for new contributors!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants